Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Fix the implementation of scaling test in HGCalRecHitProducers #47269

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Feb 5, 2025

PR description:

This PR fixes the implementation of scaling test in HGCalRecHitProducers by scaling up both the input digi collection and the corresponding calibration parameters. The scaling behavior is also put under the flag HGCAL_PERF_TEST (disabled by default) to avoid additional cost on the nominal usage of the producer.

PR validation:

Code compiles and passes local tests.

@pfs @IzaakWN

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • RecoLocalCalo/HGCalRecAlgos (upgrade, reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @bsunanda, @cseez, @denizsun, @edjtscott, @felicepantaleo, @hatakeyamak, @lgray, @missirol, @pfs, @rchatter, @rovere, @salimcerci, @sameasy, @sethzenz, @thomreis, @vandreev11, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor Author

hqucms commented Feb 5, 2025

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-da627f/44222/summary.html
COMMIT: fd7399c
CMSSW: CMSSW_15_0_X_2025-02-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/47269/44222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016960
  • DQMHistoTests: Total failures: 79
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016861
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 5, 2025

+1

@Moanwar
Copy link
Contributor

Moanwar commented Feb 5, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@pfs
Copy link
Contributor

pfs commented Feb 5, 2025

assign hgcal-dpg

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

New categories assigned: hgcal-dpg

@cseez,@felicepantaleo,@pfs,@rovere you have been requested to review this Pull request/Issue and eventually sign? Thanks

@pfs
Copy link
Contributor

pfs commented Feb 5, 2025

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 24690bd into cms-sw:master Feb 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants